Skip to content

FE-622: Restore tools-panel flicker fix lost in FE-616 refactor#123

Open
kostandinang wants to merge 2 commits into
mainfrom
ka/fe-622-restore-flicker-fix
Open

FE-622: Restore tools-panel flicker fix lost in FE-616 refactor#123
kostandinang wants to merge 2 commits into
mainfrom
ka/fe-622-restore-flicker-fix

Conversation

@kostandinang
Copy link
Copy Markdown
Contributor

@kostandinang kostandinang commented May 11, 2026

What

Restores the tools-panel flicker fix from FE-622 (PR #62), which was unintentionally reverted in FE-616 (PR #58) during the workflow-ownership refactor.

Noticed during testing — I recalled this had been fixed before; the original fix was lost along the way.

Root cause

liveToolsRunning OR'd each tool's per-event isRunning flag. Between tool A finishing and tool B starting, every tool is briefly non-running — the flag flips false, Task's auto-close timer fires, and the panel reopens when the next tool arrives.

Change

interview-controller.ts — derive liveToolsRunning from "any tool item exists AND chat status is streaming/submitted" instead of per-tool isRunning. Stable across the gap between tools.

Same one-line fix as FE-622. The companion task.tsx change isn't restored — FE-626 (#65) replaced it with re-arm logic that's harmless once the controller flag is stable.

Test plan

  • Trigger a multi-tool assistant turn in /specification/$id/{phase} — tools panel opens once and stays open until the turn finishes

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 11, 2026

PR Summary

Low Risk
Small UI-state logic change that only affects when the tools panel is considered "running" during chat streaming; low risk but could alter panel visibility timing.

Overview
Prevents the tools panel from flickering open/closed between sequential tool calls in a single assistant turn by changing liveToolsRunning to depend on tool-item presence plus chat status (submitted/streaming), rather than per-tool transient "running" states.

Simplifies live tool tracking by removing the RUNNING_TOOL_STATES set and the per-item isRunning flag from getLiveToolItems.

Reviewed by Cursor Bugbot for commit 35de8a5. Bugbot is set up for automated code reviews on this repo. Configure here.

@kostandinang kostandinang self-assigned this May 11, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 11, 2026

🤖 Augment PR Summary

Summary: Restores the controller-side tools panel flicker fix regressed in FE-616 by keeping the “tools running” signal stable across sequential tool calls.
Change: liveToolsRunning now derives from the presence of any live tool items plus chat status (streaming/submitted), rather than OR-ing per-tool isRunning flags that can briefly drop to false between tool events.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2e9015e. Configure here.

Comment thread src/client/routes/specification/$id/_view/-interview-controller.ts
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kostandinang kostandinang requested a review from lunelson May 11, 2026 13:13
@kostandinang kostandinang changed the title FE-622: Restore tools panel flicker fix (regressed in FE-616) FE-622: Restore tools-panel flicker fix lost in FE-616 refactor May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant