H-5549: Add support for sending Petri net simulation state back to Hazel #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+94
to
+97
| setSyntax({ | ||
| netDefinition: defaultNetDefinition, | ||
| simulationState: stripEmptyTuple(simulationState), | ||
| }); |
There was a problem hiding this comment.
Bug: Uses stale simulationState value in error case. When the net definition is invalid, setSimulationState() is never called (only called on line 88 in the valid case), so the simulationState variable contains stale data from a previous render. This sends incorrect simulation state back to Hazel.
Fix: Reset simulation state before calling setSyntax:
setSimulationState([]);
setSyntax({
netDefinition: defaultNetDefinition,
simulationState: undefined,
});
Suggested change
| setSyntax({ | |
| netDefinition: defaultNetDefinition, | |
| simulationState: stripEmptyTuple(simulationState), | |
| }); | |
| setSimulationState([]); | |
| setSyntax({ | |
| netDefinition: defaultNetDefinition, | |
| simulationState: undefined, | |
| }); |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
TimDiekmann
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Hazel livelit wrapper to also report back the simulation state as well as the net definition.