Skip to content

Bug fix: invalid name of devices#28

Merged
s3inlc merged 1 commit intomasterfrom
bug/invalid_device_name
Jun 5, 2022
Merged

Bug fix: invalid name of devices#28
s3inlc merged 1 commit intomasterfrom
bug/invalid_device_name

Conversation

@zyronix
Copy link
Copy Markdown
Member

@zyronix zyronix commented May 24, 2022

On some platforms PCI devices can become nested, this causes there to be one more column in the device name.

Example:

72:00:0000.0 VGA compatible controller: NVIDIA Corporation TU104 [GeForce RTX 2080] (rev a1)

# versus:

72:00.0 VGA compatible controller: NVIDIA Corporation TU104 [GeForce RTX 2080] (rev a1)

This will mark the device as a VGA compatible controller and not as NVIDIA Corporation TU104 [GeForce RTX 2080] (rev a1)

This pull requests fixes that.

The following images show the bug in action and the fix. The first agent is added using the old agent, the second is added after the fix.

image

@zyronix zyronix requested a review from s3inlc May 24, 2022 14:48
@zyronix zyronix added the bug Something isn't working label May 24, 2022
@s3inlc s3inlc merged commit 255e4e6 into master Jun 5, 2022
@s3inlc s3inlc deleted the bug/invalid_device_name branch June 5, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants