Skip to content

Minor devcontainer improvements #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s3inlc merged 1 commit into from
Jun 29, 2022
Merged

Minor devcontainer improvements #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
FROM nvidia/cuda:11.4.3-devel-ubuntu20.04
FROM ubuntu:20.04

ARG DEV_CONTAINER_USER_CMD

# Avoid warnings by switching to noninteractive
ENV DEBIAN_FRONTEND=noninteractive

# Check for and run optional user-supplied command to enable (advanced) customizations of the dev container
RUN [ -n "${DEV_CONTAINER_USER_CMD}" ] \
&& echo "${DEV_CONTAINER_USER_CMD}" | sh
RUN if [ -n "${DEV_CONTAINER_USER_CMD}" ]; then echo "${DEV_CONTAINER_USER_CMD}" | sh ; fi

RUN groupadd vscode && useradd -rm -d /app -s /bin/bash -g vscode -u 1001 vscode

Expand Down
5 changes: 0 additions & 5 deletions .devcontainer/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ services:
# This is where VS Code should expect to find your project's source code
# and the value of "workspaceFolder" in .devcontainer/devcontainer.json
- ..:/app/src
deploy:
resources:
reservations:
devices:
- capabilities: [gpu]

networks:
default:
Expand Down