Removed not working transaction for updating hash length#1979
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes an invalid database transaction wrapper from Util::setMaxHashLength() because the function executes DDL (ALTER TABLE), which triggers an implicit commit in MySQL and can cause commit() to fail with “no active transaction”.
Changes:
- Removed
beginTransaction()inUtil::setMaxHashLength(). - Removed the corresponding
commit()inUtil::setMaxHashLength().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
s3inlc
approved these changes
Mar 16, 2026
jessevz
deleted the
1626-bug-decreasing-max-length-of-a-hash-returns-http-500
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the update hash length function, a database transaction was made around an alter statement. This does not work, because a DDL statement cause an implicit commit (https://dev.mysql.com/doc/refman/8.4/en/implicit-commit.html), thus when our commit statement is reached, there is no transaction anymore, resulting in an error.
closes #1626