Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a bug where ContentLengthMiddleware was calculating the content length before DeflateEncoder compressed the response body, causing incorrect Content-Length headers and client timeouts on large responses like openapi.json.
Changes:
- Reordered Slim middleware so
ContentLengthMiddlewareruns afterDeflateEncoderon the response path, ensuring content length reflects the compressed body size. - Removed
JSON_PRETTY_PRINTfrom the OpenAPI schema JSON encoding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/api/v2/index.php |
Moved ContentLengthMiddleware after DeflateEncoder in the middleware stack |
src/inc/apiv2/common/openAPISchema.routes.php |
Removed JSON_PRETTY_PRINT flag from JSON encoding |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
s3inlc
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the backend, the content length was generated before compressing the payload. The reult was for big files like the openapi.json is that the content length would be too big, making the server time out waiting for data it wont receive