Conversation
added 2 commits
March 16, 2026 15:58
… ambigious keys because taskwrapper and task share columns with the same name
There was a problem hiding this comment.
Pull request overview
This PR addresses filter parsing and pagination SQL generation in the API/DBA layers, fixing backend errors caused by commas in single-value filters and correcting ambiguous-column issues in task pagination queries.
Changes:
- Update filter parsing so only
__in/__nintreat commas as multi-value separators; other operators treat commas as literal characters. - Fix
PaginationFilterquery generation to consistently prefix columns with the correct table name whenincludeTableis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/inc/apiv2/common/AbstractBaseAPI.php |
Adjusts filter value splitting to avoid breaking single-value operators when the value contains commas. |
src/dba/PaginationFilter.php |
Adds missing table prefixes in the pagination WHERE clause to prevent ambiguous column errors (notably for tasks). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
s3inlc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes 2 things: it solves that filters that allow only 1 value to contain ','. And it fixes a bug in pagination for tasks because the pagination filter did not use the $factory for the table correctly. Which resulted in an error for the task table because of ambigious column.
closes #1978