Skip to content

Conversation

@zyronix
Copy link
Member

@zyronix zyronix commented Apr 7, 2022

Continued the work of @SherlockNL on the supertask runtime estimation pull request. See for more information #696

Show estimated total runtime of a supertask, allowing the user to interactively come to the desired size of a supertask by adding or removing subtasks on the supertask detail page

Features:

  • Allow adding and removing subtasks to supertask
    
  • Save line count of dictionary files and rule files in database
    
  • Parse hashcat commands to compute keyspace size. Gratefully uses the code submitted by shivanraptor in #672 
    
  • Thank you, shivanraptor, for sharing your code with the community!
    
  • Compute runtime per pretask of supertask, depending on benchmark values entered by the user
    
  • Currently supports -a0 and -a3 hashcat attacks. Adds 'Unknown' to total runtime estimate when not every subtask runtime could be estimated
    
  • Supports custom charsets for masks in -a3 attacks
    

Future work and additional remarks:

  • To do: add support for other hashcat attack modes
    
  • To do: make the hashcat command parser more robust towards syntax differences in hashcat commands. Note however, that some of these are already taken into account in this commit, such as the difference between "-a0" and "-a 0" for example, or when the command includes consecutive spaces
    
  • Note: the runtime estimate entirely depends on parsing hashcat commands. A pretask meant to be run by another cracker will result in an unknown runtime estimate.
    

Implemented feedback of @s3inlc and merged master into the pull request.

SherlockNL and others added 12 commits March 16, 2021 15:56
Show estimated total runtime of a supertask, allowing the user to interactively size a supertask by adding or removing subtasks
* Allow adding and removing subtasks to supertask
* Parse hashcat command to compute runtime per subtask. Gratefully uses the code submitted by shivanraptor in #672
* Save line count of dictionary files and rule files in database
* Compute runtime per subtask of supertask, depending on benchmark values entered by the user
* Works for -a0 and -a3 hashcat attacks. Adds 'Unknown' to runtime estimate when not every subtask runtime could be estimated
* Feature includes custom charsets for masks in -a3 attacks
change todo comments

ensure generic cracker attacks result in an unknown runtime estimate

add lineCount to initial sql file

update changelog
Change button color of add to grey
@zyronix zyronix added the new feature New feature to be added label Apr 7, 2022
@zyronix zyronix requested a review from s3inlc April 7, 2022 15:17
@s3inlc s3inlc merged commit 4db87dd into master Apr 9, 2022
@s3inlc s3inlc deleted the supertask-runtime-estimate branch April 9, 2022 11:47
xasser added a commit to xasser/server that referenced this pull request Apr 17, 2022
…-runtime-estimate"

This reverts commit 4db87dd, reversing
changes made to a907491.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature to be added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants