Skip to content

Conversation

@jessevz
Copy link
Contributor

@jessevz jessevz commented Sep 25, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes cached information at detail pages by implementing a mechanism to prevent state persistence on detail pages. The solution introduces an isDetailPage flag that prevents table settings (pagination, sorting, search filters) from being stored in local storage when viewing detail pages.

  • Introduces isDetailPage flag to distinguish detail pages from main list pages
  • Updates multiple table components to use the new flag appropriately
  • Modifies files component to use dynamic table names for different file types

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/app/files/files.component.ts Adds dynamic naming for file tables based on file type
src/app/files/files.component.html Updates table component to use dynamic name binding
src/app/core/_models/config-ui.model.ts Adds separate table configurations for different file types
src/app/core/_datasources/files.datasource.ts Adds isDetail flag to files datasource
src/app/core/_datasources/chunks.datasource.ts Adds isDetail flag and sets it when agent ID is configured
src/app/core/_components/tables/ht-table/ht-table.component.ts Core logic to conditionally store table settings based on isDetailPage flag
Multiple table component HTML files Updates table components to include isDetailPage flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jessevz
Copy link
Contributor Author

jessevz commented Sep 25, 2025

eslint errors because of any, please merge it anyway :)

@cv5ch cv5ch merged commit 8a39b52 into dev Sep 26, 2025
1 of 2 checks passed
@cv5ch cv5ch deleted the detail-page-caching branch September 26, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants