2023 bug sorting on included section broken#610
Merged
Conversation
cv5ch
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent field has been missing in existing type and added zod validation schema and was therefore stripped away when trying to store user sorting preference 'task.taskName' -> only 'taskName' is stored.
This is a problem as the request sent to the backend will be 'taskName' after storing in localStorage which will fail.
Therefore also store the parent. Better solution here would probably be not to store the parent separately from the column field but store both together as a single string. But this is a quickfix to allow releasing the new version.
Also if people already have stored sorting in their local storage before the addition of included field sorting by the backend this pr will not fix this existing issue. This cannot be validated with the zod schema as we do not know which column fields require a parent and which do not. Maybe with improved typing and validation this issue can be mitigated completely.