2134 fix checkmark alignment in icon-only table cells#696
Draft
correct-horse-battery-bench wants to merge 1 commit into
Draft
2134 fix checkmark alignment in icon-only table cells#696correct-horse-battery-bench wants to merge 1 commit into
correct-horse-battery-bench wants to merge 1 commit into
Conversation
Icon-only columns (e.g. the boolean check_circle cells in the hashtype table) render the empty ht-table-* wrappers before the icon. The ht-table-editable host keeps flex: 1 1 auto, so even when empty it expands and pushes the trailing icon to the cell's right edge, away from the left-aligned column header. Collapse that wrapper (flex: 0 0 auto) and drop the optical margin nudge for these cells so the icon sits flush-left and vertically centered, matching the header. Scoped via :not(.text):not(.links) so icon+text and icon+link cells keep their existing layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT
Fix icon in cell being misaligned
Issue: hashtopolis/server#2134