Skip to content

Rewrite as a Docker container action written in Haskell. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chungyc merged 34 commits into from
Apr 6, 2023
Merged

Rewrite as a Docker container action written in Haskell. #10

chungyc merged 34 commits into from
Apr 6, 2023

Conversation

@chungyc
Copy link
Member

@chungyc chungyc commented Apr 6, 2023

The rewrite works, with a few minor and major warts remaining.

  • GitHub does not recognize the locations in the SARIF file. This probably needs a fix to the checkout_uri parameter to the REST API.
  • Code needs a lot of cleanup and documentation. Some code dirtiness is intentionally left in for testing out the action.
  • Needs automated testing. At least it will be a lot easier now.

chungyc added 30 commits April 5, 2023 02:51
@chungyc
Initial setup for Haskell Stack project.
92b7f17
@chungyc
Reflect its new location.
eb36383
@chungyc
Basic code structure.
821df7c
@chungyc
Clean up duplicate autogenerated module, and set up doctest.
f9e56d5
@chungyc
Very high-level structure.
d83bc76
@chungyc
Minimum setup for testing Docker action.
cf65328
@chungyc
Working translation of inputs to hlint flags.
ce9b70a
@chungyc
Build with unreleased version of HLint with SARIF support.
d62fdd5
@chungyc
Get consistent versions building together.
8297312
@chungyc
Print output from HLint.
4a6d002
@chungyc
Rough outline for fingerprinting.
4bcc40d
@chungyc
Build completely statically so it can run in a minimal Docker image.
96ab27d
@chungyc
Hook in input validation.
d5d51ea
@chungyc
Compute partial fingerprint.
db18110
@chungyc
Initial implementation for filling partial fingerprints.
431872b
@chungyc
Better debugging output.
b6a262f
@chungyc
Static building did not work out.
5e92a04
@chungyc
Implemented conversion to request for GitHub.
4a30e6f
@chungyc
Complete implementation, although may not be working yet.
145924e
@chungyc
Fix environment variables printing.
1ceebfd
@chungyc
Fix reading from wrong environment variable.
876e33b
@chungyc
Hide category input for now.
27eb5da
@chungyc
Enable permissions for security-events writes.
08e09cb
@chungyc
Properly print output.
33b8408
@chungyc
Clear debugging output no longer needed.
2c4066d
@chungyc
Add other debugging output.
1b9494f
@chungyc
Explicitly pass in token.
053e3a8
@chungyc
Safely read sarif-id.
e5e8127
@chungyc
Use algorithm guaranteed to be stable for partial fingerprints.
dc2fbe8
@chungyc
Fix key name.
0b36ef3
@chungyc chungyc linked an issue Apr 6, 2023 that may be closed by this pull request
Consider a rewrite as a Docker action #7
Closed
@chungyc chungyc merged commit e2c6de5 into main Apr 6, 2023
@chungyc chungyc deleted the haskell branch April 6, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider a rewrite as a Docker action

2 participants

@chungyc