Skip to content

Build with GHC 9.6#673

Merged
kmicklas merged 1 commit intohaskell-beam:masterfrom
mightybyte:ghc-9.6
Jun 12, 2023
Merged

Build with GHC 9.6#673
kmicklas merged 1 commit intohaskell-beam:masterfrom
mightybyte:ghc-9.6

Conversation

@mightybyte
Copy link
Contributor

Import changes to build with GHC 9.6. This patch serves my purposes for now, but if you need to do things differently to preserve backwards compatibility, feel free to adapt as necessary.

@LaurentRDC
Copy link
Member

Thank you for making the the code changes.

There are still some changes required on the packaging side in order for the beam repository to be buildable with GHC 9.6, for example:

  • Bumping the upper bound on ghc-prim from <0.10 to <0.11;
  • Bumping the upper bound on fgl from <5.8 to <5.9;

Outside of the beam repository, the following is required:

For example, to build and test beam-core from this pull request, one must do:

cabal test beam-core --allow-newer=ghc-prim,mtl,pqueue:base,unix,hint:ghc,fgl

@kmicklas
Copy link
Member

Can you rebase this? I will merge if it passes CI for the current GHC versions. (Working on updating CI to all the newer GHCs soon.)

Copy link
Member

@kmicklas kmicklas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't complete, but it gets us closer and I verified it doesn't break older versions.

@kmicklas kmicklas merged commit 821ac2f into haskell-beam:master Jun 12, 2023
@kmicklas kmicklas mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants