Conversation
Member
|
Thank you for making the the code changes. There are still some changes required on the packaging side in order for the beam repository to be buildable with GHC 9.6, for example:
Outside of the beam repository, the following is required:
For example, to build and test cabal test beam-core --allow-newer=ghc-prim,mtl,pqueue:base,unix,hint:ghc,fgl |
Member
|
Can you rebase this? I will merge if it passes CI for the current GHC versions. (Working on updating CI to all the newer GHCs soon.) |
kmicklas
approved these changes
Jun 12, 2023
Member
kmicklas
left a comment
There was a problem hiding this comment.
This isn't complete, but it gets us closer and I verified it doesn't break older versions.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import changes to build with GHC 9.6. This patch serves my purposes for now, but if you need to do things differently to preserve backwards compatibility, feel free to adapt as necessary.