Kill the printing of "Handling" to stderr#30
Merged
Conversation
7bf75e9 to
ae296b3
Compare
Collaborator
Author
|
@dmjio would you like to take a look? This has caused me so much confusion! Only now I properly realized that this gets printed always!! |
Contributor
|
Yea that looks problematic. Killing it is fine with me. |
The `"Handling " <> show e` message would get printed to the stderr of the dap server. This resulted in thinking something was wrong in inumerous occasions, seeing messages such as: ``` [stderr] DAP.Se [stderr] rver/Handling: [stderr] ghc-internal:GHC.Internal.IO.Exception [stderr] .IOException: <socket: 13>: Da [stderr] ta.ByteString.hGetLine: end of file IPE backtrac [stderr] e: [stderr] DAP.Server [stderr] .getHeaderHandle (src/DAP/Server.hs:(217,1)-(220,32)) HasCallStack backtrace: ioException, called at [stderr] libraries/ghc-internal/src/GHC/Internal/IO/H [stderr] andle/Internals.hs:353:11 in ghc- [stderr] internal:GHC.Internal.IO.Handle.Interna [stderr] ls ``` (I had slightly tweaked the message to investigate what was going wrong) When, in reality, nothing was wrong. This was an EOF exception indicating the client had closed the connection. However, when looking at the logs, the "Handling" was misleading (and not easily correlated with the "Client has ended its connection below". All in all, I don't think we should print the "Handling" at all. If an exception is handled, it is handled. If it is not, then it gets logged to the appropriate logger as "Unknown Exception".
ae296b3 to
02e5f7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.