Reduce operation type repetition #212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh
approved these changes
Jan 12, 2019
|
I am happy to be able to help a little bit 😄 |
|
I got confused by the github interface and merged master into this branch instead of the other way round. @thiagorp you OK with me cherry-picking your changes into master? Alternatively if you want to go with the PR would you mind creating a new one? There doesn't seem to be a way of backing out the merge.. |
|
Hey @teh, I am ok with both options. I will create a new PR now so in case you prefer this approach you are not blocked by me. But feel free to also cherry-pick if you find it better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the operation type as a parameter of the Operation data constructor as suggested on the comment.