Improve type safety on operation interpreting #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagorp
changed the title
teh
approved these changes
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of a series of PR's I am doing as small improvements that are suggesting on the code itself.
This constraints the resolving of the operation (or the root of the query) to only objects. Removing the unnecessary check that was done checking if the result of the resolving was indeed an object or not.
I want to implement schema introspection and for that I have been reading the code to understand where and how to add it. To be able to handle the
__schemafield, it's necessary a resolver that we are sure that is the entrypoint so we can build up the schema downwards from it. This change makes it possible.