記事の追加: HspecでQuickCheckするときもshouldBeなどが使えます #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotz84
reviewed
Feb 15, 2020
lotz84
reviewed
Feb 15, 2020
Contributor
|
コメントしたところ以外は LGTM です 🙆 読みやすくてわかりやすかったです |
Member
Author
|
haskell-jp-botがコメントしたartifactのURLが有効じゃない問題が起きてます。 |
igrep
commented
Feb 15, 2020
| headingDivClass: post-heading | ||
| author: Yuji Yamamoto | ||
| postedBy: <a href="http://the.igreque.info/">Yuji Yamamoto(@igrep)</a> | ||
| date: February 26, 2020 |
Member
Author
There was a problem hiding this comment.
恐らくもうすぐ公開できるので、日付を変えるの忘れないようにしないと
Member
Author
|
@lotz84 指摘箇所は修正済みなので、お手すきの際にご確認いただきたく！ 🙏 |
Member
Author
|
すみません、このまま何もなければ今日中に日付を変えて公開します。軽微な修正ですし。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.