Skip to content

Don't use * as Type in the presence of TypeOperators #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolmodin merged 1 commit into from
Jun 7, 2018
Merged

Don't use * as Type in the presence of TypeOperators #148

kolmodin merged 1 commit into from
Jun 7, 2018

Conversation

@int-index
Copy link
Contributor

@int-index int-index commented May 29, 2018

No description provided.

@int-index int-index mentioned this pull request Jun 5, 2018
Merged
@int-index
Copy link
Contributor Author

int-index commented Jun 5, 2018

I need this for https://phabricator.haskell.org/D4748

@kolmodin
Copy link
Member

kolmodin commented Jun 6, 2018

From Travis,


src/Data/Binary/Generic.hs:30:8:
    Could not find module `Data.Kind'
    Use -v to see a list of the files searched for.

does this change work with older GHCs?

@int-index
Copy link
Contributor Author

int-index commented Jun 6, 2018

does this change work with older GHCs?

Not yet. I'll add CPP conditionals to fix it.

@int-index
Copy link
Contributor Author

int-index commented Jun 7, 2018

This now builds on all GHC versions from 7.4.2 to 8.4.3

@kolmodin kolmodin merged commit 6eedd64 into haskell:master Jun 7, 2018
@int-index int-index deleted the no-star branch June 7, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@int-index @kolmodin