Use unsafe shifts from base rather than hand-rolling #178
Conversation
|
@Ericson2314, this was an oversight on my part; thanks for doing this! Can we get this merged, @kolmodin? |
|
https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4492 is now just blocked on upstream libraries approving these PRs. (The current rebuild as I write this is just from me changing the a changeg log message.) |
|
According to haskell/bytestring#326 these manual unboxed shifts for static shit amounts are no longer needed at all. |
See https://hackage.haskell.org/package/base-4.5.0.0/docs/Data-Bits.html#v:unsafeShiftL. in binary's minimum supportedbase version. Beyond reducing duplicated code, this will avoid CPP in dealing with the changing primop situation for GHC 9.2.
Ericson2314
force-pushed
the
wip/no-extend-narrow-primop-names
branch
from
51ce49d to
1c07fd5
Compare
|
And even better, |
Ericson2314
changed the title
|
@kolmodin Can we merge this? It no longer makes any assumptions about the state of 9.2. As you can see in the description of https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4492, some of the others have gotten merged. |
|
Pinging @kolmodin? |
|
Looks good. The |
2 participants
This is a companion to https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4492.
I'm not sure why the second-to-top commit isn't already merged, as ghc HEAD relies on it.
CC @bgamari