Cabal API change in 3.14 requires a lower bound bump in cabal-install #10882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Mar 28, 2025
Collaborator
|
Hm, right, since that hasn't been released yet it'll be hard to test in CI… |
Collaborator
|
Hack: change |
ulysses4ever
force-pushed
the
cabal-api-change-3.14
branch
from
1c6dc6b to
14a83a4
Compare
Collaborator
Author
|
@geekosaur but I thought it'd use the local versions. Well, local version was 3.14.1.1, which isn't true. I bumped it to 3.14.2. |
Collaborator
|
It'll only use the local version if its version matches the constraint. Since the local one doesn't match |
Collaborator
Author
|
it does now |
Collaborator
Author
|
@Mikolaj is this an okay patch? I don't want to merge it before someone else looks... |
Mikolaj
approved these changes
Mar 28, 2025
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
I don't know if it's going to work, but it looks legit on its own.
Collaborator
|
It should work once my check-sdist update lands, which requires fixing |
Mikolaj
force-pushed
the
cabal-api-change-3.14
branch
from
14a83a4 to
27f243e
Compare
…ds a lower bound bump the function in question is `addInternalBuildToolsFixed` (introduced in #10838)
Mikolaj
force-pushed
the
cabal-api-change-3.14
branch
from
27f243e to
412c088
Compare
mergify
bot
added
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cabal-install on 3.14 depends on an unreleased Cabal fuction, so, needs a lower bound bump. The function in question is
addInternalBuildToolsFixed(introduced in #10838).This was found by the CI sdist-check job in #10865
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: