Add check for "dotlines" with cabal 3.0+#11571
Conversation
61c1fc5 to
9fbdaaa
Compare
9fbdaaa to
11d71af
Compare
11d71af to
050a595
Compare
06a5812 to
eb39fa5
Compare
|
Not really sure what the lone failure is about. It's I'm not seeing any obvious reasons, like network errors or output mismatch. 🤷 |
|
It's a sporadic failure with ghc 9.2.8 on Windows: |
de4c464 to
2920543
Compare
f5b3e89 to
94e0bc8
Compare
|
Embarrassing oversight: I just realized the original PR added the check to Right now it's a separate commit so the difference is easier to see, but I intend to squash them into one commit once I get confirmation that Apologies for the churn! Edit: Went ahead with the squash. The diff against the prior commit can be seen here. |
af20174 to
e12888b
Compare
Cabal 3.0 changed the parser for "free text" fields (e.g. description)
such that:
1. Empty lines and indentation are preserved.
2. Empty lines with a dot '.' (and possible whitespace) are
interpreted literally; they are no longer interpreted as an
empty line.
Consequently, dotlines no longer serve a purpose and only add extra
noise, hence are given a warning with check.
See haskell#11518.
e12888b to
2621a7f
Compare
Adds a
cabal checkfor #11518.Click to expand outdated explanation
Adds a warning for #11518. I'm not too familiar with this part of the codebase, but the changes seem straightforward.Essentially wraps
with
which adds a warning if the string matches the same dot check pre-3.0 (
trim bs == "."). The rest is just mechanical changes to accommodate theParseResult.~~Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.