Skip to content

Add check for "dotlines" with cabal 3.0+#11571

Open
tbidne wants to merge 1 commit intohaskell:masterfrom
tbidne:tbidne/11518-check
Open

Add check for "dotlines" with cabal 3.0+#11571
tbidne wants to merge 1 commit intohaskell:masterfrom
tbidne:tbidne/11518-check

Conversation

@tbidne
Copy link
Contributor

@tbidne tbidne commented Mar 3, 2026

Adds a cabal check for #11518.

Click to expand outdated explanation Adds a warning for #11518. I'm not too familiar with this part of the codebase, but the changes seem straightforward.

Essentially wraps

fromUTF8BS :: ByteString -> String

with

parseLine3 :: Position -> BS.ByteString -> ParseResult src String

which adds a warning if the string matches the same dot check pre-3.0 (trim bs == "."). The rest is just mechanical changes to accommodate the ParseResult.~~


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@tbidne tbidne force-pushed the tbidne/11518-check branch from 61c1fc5 to 9fbdaaa Compare March 3, 2026 23:34
@tbidne tbidne force-pushed the tbidne/11518-check branch from 9fbdaaa to 11d71af Compare March 4, 2026 00:46
@tbidne tbidne force-pushed the tbidne/11518-check branch from 11d71af to 050a595 Compare March 4, 2026 10:31
@tbidne tbidne force-pushed the tbidne/11518-check branch 3 times, most recently from 06a5812 to eb39fa5 Compare March 4, 2026 19:44
@tbidne
Copy link
Contributor Author

tbidne commented Mar 4, 2026

Not really sure what the lone failure is about. It's Backpack\T5634 with the lib-suite test:

*** unexpected failure for PackageTests\Backpack\T5634\setup.test.hs

ci log

I'm not seeing any obvious reasons, like network errors or output mismatch. 🤷

@geekosaur
Copy link
Collaborator

It's a sporadic failure with ghc 9.2.8 on Windows: ghc-pkg exits with failure but no messages. It'll happen for a while (up to a couple hours) and then start working again.

@tbidne tbidne force-pushed the tbidne/11518-check branch 4 times, most recently from de4c464 to 2920543 Compare March 11, 2026 21:24
@Bodigrim Bodigrim added the merge me Tell Mergify Bot to merge label Mar 16, 2026
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Mar 16, 2026
@tbidne tbidne force-pushed the tbidne/11518-check branch 2 times, most recently from f5b3e89 to 94e0bc8 Compare March 16, 2026 23:02
@tbidne
Copy link
Contributor Author

tbidne commented Mar 16, 2026

Embarrassing oversight: I just realized the original PR added the check to cabal build, not cabal check. I rectified this, so it's now on check (the test verifies that build is unaffected).

Right now it's a separate commit so the difference is easier to see, but I intend to squash them into one commit once I get confirmation that check is what we want.

Apologies for the churn!

Edit: Went ahead with the squash. The diff against the prior commit can be seen here.

@tbidne tbidne force-pushed the tbidne/11518-check branch 2 times, most recently from af20174 to e12888b Compare March 17, 2026 02:35
Cabal 3.0 changed the parser for "free text" fields (e.g. description)
such that:

  1. Empty lines and indentation are preserved.

  2. Empty lines with a dot '.' (and possible whitespace) are
     interpreted literally; they are no longer interpreted as an
     empty line.

Consequently, dotlines no longer serve a purpose and only add extra
noise, hence are given a warning with check.

See haskell#11518.
@tbidne tbidne force-pushed the tbidne/11518-check branch from e12888b to 2621a7f Compare March 17, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants