Open
Conversation
0ec2a49 to
4accda8
Compare
geekosaur
reviewed
Mar 14, 2026
geekosaur
approved these changes
Mar 14, 2026
4accda8 to
326631c
Compare
zlonast
reviewed
Mar 17, 2026
| threadDelay 1000 | ||
| removeFile fp | ||
| -- Else we give up. | ||
| | otherwise -> throwIO e |
Collaborator
There was a problem hiding this comment.
In Haskell, we have very poor support for Windows operating system errors. The libraries provided by the compiler don't have a comprehensive manual catch for these errors for Windows. Essentially, we only catch errors on Linux and Mac (so-called errno). I think this will also silently crash, like renameFileWithRetry.
zlonast
approved these changes
Mar 17, 2026
Collaborator
zlonast
left a comment
There was a problem hiding this comment.
Personally, I like this pull request, just like renameFileWithRetry. But it doesn't prevent the silent death of the build on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11606.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.