Skip to content

Handle removing files better#11616

Open
Bodigrim wants to merge 2 commits intomasterfrom
removeFileForcibly
Open

Handle removing files better#11616
Bodigrim wants to merge 2 commits intomasterfrom
removeFileForcibly

Conversation

@Bodigrim
Copy link
Collaborator

@Bodigrim Bodigrim commented Mar 14, 2026

Closes #11606.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@Bodigrim Bodigrim force-pushed the removeFileForcibly branch from 0ec2a49 to 4accda8 Compare March 14, 2026 15:16
threadDelay 1000
removeFile fp
-- Else we give up.
| otherwise -> throwIO e
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Haskell, we have very poor support for Windows operating system errors. The libraries provided by the compiler don't have a comprehensive manual catch for these errors for Windows. Essentially, we only catch errors on Linux and Mac (so-called errno). I think this will also silently crash, like renameFileWithRetry.

Copy link
Collaborator

@zlonast zlonast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I like this pull request, just like renameFileWithRetry. But it doesn't prevent the silent death of the build on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle removing files better

3 participants