Mark output in LogProgress#11753
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Apr 22, 2026
Merged
Conversation
sheaf
force-pushed
the
mark-logProgress
branch
2 times, most recently
from
1af3dfb to
d54a5eb
Compare
Collaborator
Author
|
CI is passing, just a spurious network blip in one of the jobs. |
geekosaur
approved these changes
Apr 17, 2026
Collaborator
Author
|
Anyone else willing to review? Very straightforward change. It's mainly motivated by #11703 because, in that patch, we more often go via the |
Cabal's Distribution.Utils.LogProgress module failed to take into
account whether we are marking output or not, and simply never included
output markers.
We also make sure that warnings go to stderr not stdout, to be
consistent with `Distribution.Simple.Utils.warnMessage`.
In summary, the impact is that:
- warning messages now consistently go to stderr
- when running the testsuite, we are more consistent in tagging
messages emitted by Cabal, with the 'BEGIN CABAL OUTPUT'/'END CABAL OUTPUT'
markers.
3 tasks
Collaborator
I see no changes in testsuite outputs. Is that expected? |
Collaborator
Author
Yes, it turned out there weren't any tests that needed updating as none of the test that use marked output were going via the LogProgress codepath. That was not the case for the "info messages" (mostly Backpack debugging messages), which is why I kept them non-marked (otherwise a huge amount of tests needed to adapt to new output because of gobs of Backpack noisy output). |
philderbeast
approved these changes
Apr 20, 2026
sheaf
added
merge me
mergify
Bot
added
ready and waiting
Contributor
Merge Queue Status
This pull request spent 10 minutes 8 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cabal's
Distribution.Utils.LogProgressmodule failed to take into account whether we were marking output or not, and simply never included output markers. This PR rectifies that.We also make sure that warnings go to stderr not stdout, to be consistent with
Distribution.Simple.Utils.warnMessage.In summary, the impact is that:
BEGIN CABAL OUTPUT/END CABAL OUTPUTmarkers.TODO:
Template B: This PR does not modify behaviour or interface. It only modifies output marking, which is an internal mechanism for the testsuite.