Merged
Conversation
Member
|
Looks like this breaks some tests. |
23Skidoo
approved these changes
Jan 7, 2018
Member
23Skidoo
left a comment
23Skidoo
left a comment
There was a problem hiding this comment.
Looks OK, feel free to merge once you've fixed the test failures. I'll think about how to fix this in a more elegant way.
| globalNix :: Flag Bool, -- ^ Integrate with Nix | ||
| globalStoreDir :: Flag FilePath | ||
| globalStoreDir :: Flag FilePath, | ||
| globalProgPathExtra :: NubList FilePath |
Member
There was a problem hiding this comment.
Please add a -- ^ Haddock comment here.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve half of #4995 -- as usual, two lines of straightforward changes, and 20x as many lines to make sure the data gets threaded to where it needs to go. In this case I've added an extra prog path field to the GlobalFlags object so it can thread through to be used in looking up binaries for the http transport. It is automatically derived from the setting in the config file.