Let CI jobs run on all PRs, not just those rooted off master. #7308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to use stack diffs (https://github.com/ezyang/ghstack/) to submit PRs to Cabal. Stack diffs, simply by virtue of what they are, are PRs that are targeted to branches that are not master (they target an appropriate base that lets GitHub render only the change in question, even if there are other changes below it.) However, I don't get CI jobs on those stack diffs because the current pull_request branch selector is too restrictive. This PR makes it less restrictive. This PR is submitted using ghstack to validate that this indeed works. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Feb 28, 2021
I want to use stack diffs (https://github.com/ezyang/ghstack/) to submit PRs to Cabal. Stack diffs, simply by virtue of what they are, are PRs that are targeted to branches that are not master (they target an appropriate base that lets GitHub render only the change in question, even if there are other changes below it.) However, I don't get CI jobs on those stack diffs because the current pull_request branch selector is too restrictive. This PR makes it less restrictive. This PR is submitted using ghstack to validate that this indeed works. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: b135ea6 Pull Request resolved: #7308
Member
|
@fgaz thoughts on this one? |
Member
|
release branches do get ci though.. how does that happen? how does this interact wit it? also bootstrap is failing |
Contributor
Author
|
@fgaz IDK how release branches work; my reading of the Actions code is that they shouldn't have stuff running. But whatever this PR does, it shouldn't interfere with release branches (I'm only running more jobs, not less) Bootstrap has been failing for a while, it's unrelated to this PR. |
Member
|
@ezyang could you delete the gh/ezyang/2 branches? |
Contributor
Author
|
oops i botched this merge |
ezyang
added a commit
that referenced
this pull request
Mar 19, 2021
I want to use stack diffs (https://github.com/ezyang/ghstack/) to submit PRs to Cabal. Stack diffs, simply by virtue of what they are, are PRs that are targeted to branches that are not master (they target an appropriate base that lets GitHub render only the change in question, even if there are other changes below it.) However, I don't get CI jobs on those stack diffs because the current pull_request branch selector is too restrictive. This PR makes it less restrictive. This PR is submitted using ghstack to validate that this indeed works. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: b135ea6 Pull Request resolved: #7308
hololeap
pushed a commit
to hololeap/cabal
that referenced
this pull request
Apr 24, 2022
I want to use stack diffs (https://github.com/ezyang/ghstack/) to submit PRs to Cabal. Stack diffs, simply by virtue of what they are, are PRs that are targeted to branches that are not master (they target an appropriate base that lets GitHub render only the change in question, even if there are other changes below it.) However, I don't get CI jobs on those stack diffs because the current pull_request branch selector is too restrictive. This PR makes it less restrictive. This PR is submitted using ghstack to validate that this indeed works. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: b135ea6 Pull Request resolved: haskell#7308
hololeap
pushed a commit
to hololeap/cabal
that referenced
this pull request
Apr 24, 2022
I want to use stack diffs (https://github.com/ezyang/ghstack/) to submit PRs to Cabal. Stack diffs, simply by virtue of what they are, are PRs that are targeted to branches that are not master (they target an appropriate base that lets GitHub render only the change in question, even if there are other changes below it.) However, I don't get CI jobs on those stack diffs because the current pull_request branch selector is too restrictive. This PR makes it less restrictive. This PR is submitted using ghstack to validate that this indeed works. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: b135ea6 Pull Request resolved: haskell#7308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I want to use stack diffs (https://github.com/ezyang/ghstack/) to
submit PRs to Cabal. Stack diffs, simply by virtue of what they
are, are PRs that are targeted to branches that are not master (they
target an appropriate base that lets GitHub render only the change
in question, even if there are other changes below it.) However,
I don't get CI jobs on those stack diffs because the current
pull_request branch selector is too restrictive. This PR makes
it less restrictive.
This PR is submitted using ghstack to validate that this indeed
works.
Signed-off-by: Edward Z. Yang ezyang@fb.com