testsuite: Fix hardcoded /bin/bash in custom-cc wrapper #9634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Jan 19, 2024
mergify
bot
added
the
merge delay passed
Mikolaj
force-pushed
the
wip/bin-bash
branch
2 times, most recently
from
db76b39 to
c8db77b
Compare
Collaborator
Author
|
When can this patch be merged? |
Not all operating systems have `/bin/bash` available, it is more portable to use `/usr/bin/env bash` For example: https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash
ulysses4ever
force-pushed
the
wip/bin-bash
branch
from
c8db77b to
d35f4e6
Compare
Collaborator
|
Looked like spurious CI failure. Rebased and restarted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all operating systems have
/bin/bashavailable, it is more portable to use/usr/bin/env bashFor example: https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash
Please read Github PR Conventions and then fill in one of these two templates.
Template Β: This PR does not modify
cabalbehaviour (documentation, tests, refactoring, etc.)Include the following checklist in your PR: