Replace criterion with gauge as the benchmark framework#571
Merged
treeowl merged 1 commit intohaskell:masterfrom Apr 10, 2019
Merged
Replace criterion with gauge as the benchmark framework#571treeowl merged 1 commit intohaskell:masterfrom
treeowl merged 1 commit intohaskell:masterfrom
Conversation
Member
Author
|
For some previous discussion on using
|
Contributor
|
bump @treeowl This circular dependency is really a very annoying barrier of entry to working on containers and unordered-containers. |
Member
Author
|
Bump @treeowl. At this point, |
Member
Author
|
Bump @treeowl! How about you just merge this and give it a try? If it turns out to be a bad idea, the change should be easily reverted! The reduced barrier for new contributors should make this easily worth it. |
Contributor
|
Okay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the circular dependency on
criterioncontainers in the benchmarks.One consequence of this is that we can now simply use
cabal new-benchto run the benchmarks.