Update Setup.hs for unreleased Cabal changes#88
Closed
9999years wants to merge 1 commit intohaskell:mainfrom
Closed
Update Setup.hs for unreleased Cabal changes#889999years wants to merge 1 commit intohaskell:mainfrom
9999years wants to merge 1 commit intohaskell:mainfrom
Conversation
|
@9999years does it fix #89? Could you please finalise the PR? |
Member
|
I think this is very nearly ready, except for the following details:
That is, I would apply the following changes: diff --git a/Setup.hs b/Setup.hs
index d28a64a..fca164b 100644
--- a/Setup.hs
+++ b/Setup.hs
@@ -106,7 +106,7 @@ checkGetentropy cc lbi = do
where cArgs = ["-DHAVE_GETENTROPY"]
myRawSystemExitCode :: Verbosity -> FilePath -> [String] -> IO ExitCode
-#if __GLASGOW_HASKELL__ >= 906
+#if MIN_VERSION_Cabal(3,14,0)
-- Modified in unreleased (as of 2024-09-09) changes:
-- https://github.com/haskell/cabal/commit/7b9058328e162a4cb707b5d5b25cd1d2df66680e
-- https://github.com/haskell/cabal/commit/ee11ac6c7badc452def79116729bd16aea15c0df
diff --git a/entropy.cabal b/entropy.cabal
index 45720f0..d7650b0 100644
--- a/entropy.cabal
+++ b/entropy.cabal
@@ -47,7 +47,7 @@ Flag DoNotGetEntropy
Manual: True
custom-setup
- setup-depends: Cabal >= 1.10 && < 3.13
+ setup-depends: Cabal >= 1.10 && < 3.15
, base < 5
, filepath < 1.6
, directory < 1.4 |
Collaborator
|
Thanks See #90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.