constraints: actually forbid the unwanted packages#1509
Merged
Conversation
Intent of "forbidden packages" constraint in `cabal.project` is not effected. The current constraint does not prevent inclusion in build plan - it only ensures the packages are build without the `none` flag. Change to a `< 0` version constraint to actually prevent the unwanted packages from being used.
|
This is the right thing to do. Even though project files are not versioned, cabal files are and the
hackage-server/hackage-server.cabal Lines 1 to 2 in 8b5f771 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent of "forbidden packages" constraint in
cabal.projectis not effected. The current constraint does not prevent inclusion in build plan - it only ensures the packages are build without thenoneflag.Change to a
< 0version constraint to actually prevent the unwanted packages from being used.