User Notification emails #622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
referenced
this pull request
in tfausak/grawlix
Nov 18, 2017
|
Can I do anything to help move this forward? I really want this feature. |
Contributor
Author
|
I think this chunk should be reviewed and merged when possible. But it will need to be paired, as I mentioned, with a user-pref UI that needs to be written. Basically we need a page where logged-in users can modify these settings, and one hasn't been written. This is a standalone chunk of work that anyone can pick up, though it requires understanding how all the acid-state component stuff works, to a degree. |
Closed
Contributor
Author
|
If we had docbuilder notifications those also could be a good place to let users know what to do in the event of a build failed due to missing system packages. |
andreasabel
added
the
re: notifications
Contributor
Author
|
This is complete afaik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mergable chunk that should almost resolve #230
It has machinery for user preferences for which notifications to get, but no UI or API for them yet. Also, by default it has user preferences set to not get emails.
So it should be safe to review and merge as-is.
However, until we have a user-pref UI, nobody will be able to opt-in to it. And once that's done and we're comfortable, we can then cut over to an opt-in by default in the future.
There's also flags but no implementation work done yet for
-- notifications on pending proposed tags
-- notifications on docbuilder reports
As is it notifies on users being added to or removed from maintainer groups, and on metadata revisions and new package uploads -- which are the key things from a collaboration and transparency standpoint. The others, which can be in a future PR, are nice-to-have.