This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Bump resolvers #1019
Merged
Bump resolvers #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelpilz
reviewed
Dec 31, 2018
| @@ -1,4 +1,4 @@ | |||
| resolver: lts-12.20 # LTS 12.15 is first to support GHC 8.4.4 | |||
| resolver: lts-12.26 # LTS 12.15 is first to support GHC 8.4.4 | |||
Contributor
There was a problem hiding this comment.
minor note: some old lts is referenced here in comment, other files only reference the ghc version in the comment
Collaborator
Author
There was a problem hiding this comment.
For the nightly it changes GHC version at certain points. For the the lts, the minor version may change at certain points.
So we add comments to mark these transitions, and the "last" type comments are the most important, as they tell me not to bother trying to update the resolver again. Although I do re-do the specified deps in the stack files to see if any have advanced.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monthly bump