Fix HLS benchmark example #1420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
fix-hls-benchmark
branch
from
6c88566 to
a59a505
Compare
hie-bios is failing to run the Cabal cradle for these, failing with the error below: ``` > Build profile: -w ghc-8.10.4 -O1 > In order, the following will be built (use -v for more details): > - ghcide-0.7.5.0 (exe:ghcide-bench) (first run) > - ghcide-0.7.5.0 (bench:benchHist) (first run) > Run the 'configure' command first. > cabal: Failed to build exe:ghcide-bench from ghcide-0.7.5.0 (which is required > by bench:benchHist from ghcide-0.7.5.0). ```
pepeiborra
force-pushed
the
fix-hls-benchmark
branch
from
a59a505 to
5ab86dd
Compare
The goal is to convince Cabal to apply the ghc options only to the ghcide binary and not to all the dependencies, which causes massive rebuilds and leads to benchmarks timeouts
pepeiborra
force-pushed
the
fix-hls-benchmark
branch
from
5ab86dd to
48dbe4e
Compare
Collaborator
|
The benchmarks have changed a lot since this was opened, so I'm tenatively closing this as not needed any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the CI job succeeds, all the experiments in the example are failing due to cradle setup issues and providing no perf data