-
Notifications
You must be signed in to change notification settings - Fork 89
Add callCreateProcess
#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+34
−32
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c8523ed
Bump macos runner version
tomjaguarpaw d16f5ff
Merge cases
tomjaguarpaw 83d7b95
Pull out fun
tomjaguarpaw 1c54a6f
Pull out processFailed
tomjaguarpaw ad8c821
Pull processFailed to top level
tomjaguarpaw c16ead9
Inline fun
tomjaguarpaw 4eadd70
Pull out command
tomjaguarpaw 45f8064
Pull out command
tomjaguarpaw e75e347
Use processFailed
tomjaguarpaw 4d9b04b
Use processFailed
tomjaguarpaw 55c719b
Add and use callCreateProcess_
tomjaguarpaw 1aba383
Inline command
tomjaguarpaw 748523e
Inline command
tomjaguarpaw 8a70a64
Don't use do
tomjaguarpaw 49d685c
Don't use do
tomjaguarpaw 6e0d40d
eta reduce
tomjaguarpaw d7f3ca9
eta reduce
tomjaguarpaw fd4cb2b
Add `callCreateProcess`
tomjaguarpaw d02e214
Explain in docs that callProcess and callCommand are shorthands
tomjaguarpaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically I would be in favor of:
callCreateProcesscallCreateProcess_callCreateProcess (proc cmd args)However, technically that is a breaking change, as it will change error messages. Not sure how big of an issue that is, but when
readCreateProcesswas introduced back in 2015 error messages did change, so there is some precedence at least.From a users perspective, you don't really want a whole bunch of different functions that are all slightly different and are implemented in terms of internal primitives. What you want is:
Sadly,
processis very far from this ideal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And presumably for
callCommandtoo?I don't really have an objection to this. It makes a lot of sense and I personally don't feel strongly about just the function name changing in the error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need
spawnCreateProcesstoo!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the latter see #360