Make sorting deriving list optional #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| indentIndentStyle4 :: Config | ||
| indentIndentStyle4 = Config (Indent 4) (Indent 4) 4 4 False True SameLine False NoMaxColumns | ||
| indentIndentStyle4 = Config (Indent 4) (Indent 4) 4 4 False True SameLine False True NoMaxColumns |
Member
There was a problem hiding this comment.
It would make sense to add a test which checks whether "not sorting" actually does what it promises
Not everyone wants their typeclasses sorted.
maksbotan
force-pushed
the
maksbotan/no-sort-deriving
branch
from
2e1d65a to
6546ac3
Compare
Contributor
Author
|
Hi @lukasz-golebiewski @jaspervdj! Can you please make a Hackage release with this included? |
Member
|
@maksbotan I've uploaded it as |
tchoutri
pushed a commit
to tchoutri/stylish-haskell
that referenced
this pull request
Feb 20, 2021
* Make sorting deriving list optional Not everyone wants their typeclasses sorted. * Remove redundant code Co-authored-by: Łukasz Gołębiewski <lukasz.golebiewski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everyone wants their typeclasses sorted.