Refactor UnicodeSyntax.hs #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspervdj
approved these changes
Oct 6, 2020
Member
jaspervdj
left a comment
jaspervdj
left a comment
There was a problem hiding this comment.
Looks good! One thing to note is that this really only works because all of the Unicode Syntax symbols we're converting are in type signatures? It may be worth adding a note about that.
Member
Author
|
Are you suggesting adding a comment @jaspervdj ? Where exactly? |
jaspervdj
reviewed
Oct 7, 2020
Co-authored-by: Jasper Van der Jeugt <jaspervdj@gmail.com>
tchoutri
pushed a commit
to tchoutri/stylish-haskell
that referenced
this pull request
Feb 20, 2021
* Refactor UnicodeSyntax.hs Co-authored-by: Jasper Van der Jeugt <jaspervdj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.