Skip to content

Conversation

@soiamsoNG
Copy link
Contributor

Want to add proxy support considering below point

Amazon AWS with very slow connection around 30K/s in some area.
VSCode not support socks5 proxy in a clean way.
Node not support socks5 proxy in a clean way.

Hope can solve the AWS very slow issue in another way but not set a proxy.

@lukel97 lukel97 added type: enhancement An enhancement to an already existing feature help wanted labels Oct 17, 2020
@soiamsoNG
Copy link
Contributor Author

c53475b, let user can set a mirror path in setting

@soiamsoNG soiamsoNG changed the title Proxy Support for download Proxy or Mirror Support for download Oct 20, 2020
@soiamsoNG
Copy link
Contributor Author

40d866f
for case like set mirror path to below json, which will issue a redirect
https://github.com/soiamsoNG/haskell-language-server-via-fastgit/releases/download/0.0.1/releasesInfo.json

@jneira jneira requested a review from lukel97 October 20, 2020 05:37
@jneira
Copy link
Member

jneira commented Oct 20, 2020

@soiamsoNG only to be sure: the actual download mechanism does not honour the standard system proxy settings (http_proxy, https_proxy, etc)?

@soiamsoNG
Copy link
Contributor Author

@soiamsoNG only to be sure: the actual download mechanism does not honour the standard system proxy settings (http_proxy, https_proxy, etc)?

Thanks for your remind.

@soiamsoNG soiamsoNG closed this Oct 20, 2020
@soiamsoNG
Copy link
Contributor Author

sorry for mistake press the button

@soiamsoNG soiamsoNG reopened this Oct 20, 2020
@jneira
Copy link
Member

jneira commented Oct 20, 2020

sorry for mistake press the button

So, could you use those env variables to tell the extension the proxy to be used? If that is the case, maybe we should add to documentation, instead add extra code.

"scope": "resource",
"type": "string",
"default": "",
"description": "http:// https:// socks:// socks5:// pac+http://"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are using the vscode http proxy setting, do we need to have our own proxy configuration in this extension too? I think we can just remove this one then

Copy link
Contributor Author

@soiamsoNG soiamsoNG Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, a little bit too much, please don't pick the proxy part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create #313 for just Mirror Support part

soiamsoNG and others added 2 commits October 20, 2020 21:28
update languageServerReleasesPath discription

Co-authored-by: Luke Lau <luke_lau@icloud.com>
@soiamsoNG soiamsoNG mentioned this pull request Oct 21, 2020
@lukel97
Copy link
Collaborator

lukel97 commented Dec 12, 2020

Sorry for the late reply on this: Is this still needed? Or does the built-in vscode proxy work ok?

@soiamsoNG
Copy link
Contributor Author

No need now

@soiamsoNG soiamsoNG closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted type: enhancement An enhancement to an already existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants