Fix some render errors (Caused by Loading components) and optimize workspace switching #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tequila9513
approved these changes
Sep 10, 2018
…rkspace switching
duynguyenhoang
force-pushed
the
feature/fix_some_error_while_loading
branch
from
82c4979 to
c368490
Compare
haskellcamargo
approved these changes
Sep 10, 2018
yuriploc
added a commit
to yuriploc/sclack
that referenced
this pull request
Sep 10, 2018
The var was added in PR haskellcamargo#94, but generates an exception because is not defined. Rolling back to int(key) to address this. closes haskellcamargo#95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #92