fix: selected_workspace is not defined #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The var was added in PR haskellcamargo#94, but generates an exception because is not defined. Rolling back to int(key) to address this. closes haskellcamargo#95
duynguyenhoang
requested changes
Sep 10, 2018
app.py
Outdated
|
|
||
| # Workspace is selected | ||
| if selected_workspace - 1 == self.workspaces_line.selected: | ||
| if int(key) - 1 == self.workspaces_line.selected: |
Collaborator
There was a problem hiding this comment.
simply define selected_workspace = int(key) before this one
duynguyenhoang
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The var was added in PR #94, but generates an exception because is not defined.
Rolling back to
int(key)to address this.closes #95