Improve CI setup #246
Merged
Improve CI setup #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not fail on pull requests, properly cache dependencies
nomeata
commented
Feb 13, 2023
Contributor
|
I am not really competent to review this, TBH. My knowledge of GH actions is limited. I like that it has a green check mark, and I generally trust @nomeata to say so if his understanding is limited, so I'd be inclined to merge. Anyone else around who has a better understanding than me to check it out? |
Collaborator
|
I do not have a better understanding, bit I also trust @nomeata and confirm that CI took too long.... |
Collaborator
Author
|
We can revert when I messed up (which is possible of course) |
Contributor
|
YOLO :-) |
Collaborator
Author
|
The merge commit pr itself failed because the deploy action doesn't like it if nothing new gets deployed, but that's independent of this PR. Else looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not fail on pull requests, properly cache dependencies