fix: handle timedelta type in calculate_update_interval#46
Closed
Explorer1092 wants to merge 1 commit intohasscc:mainfrom
Closed
fix: handle timedelta type in calculate_update_interval#46Explorer1092 wants to merge 1 commit intohasscc:mainfrom
Explorer1092 wants to merge 1 commit intohasscc:mainfrom
Conversation
The CONF_SCAN_INTERVAL config value is validated by Home Assistant's cv.time_period validator, which converts the string to a timedelta object. The calculate_update_interval function was only expecting a string, causing a TypeError: "expected string or bytes-like object, got 'datetime.timedelta'". This fix adds support for both string and timedelta inputs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merged
Collaborator
|
Hey @Explorer1092, your work is included in new release v2.1.1-beta. Thanks for contributing! 🐱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONF_SCAN_INTERVALis validated by Home Assistant'scv.time_periodtimedeltaobject, butcalculate_update_intervalonly expected a stringtimedeltainputsProblem
When using YAML configuration, Home Assistant throws:
This happens because
const.pydefines:The
cv.time_periodvalidator converts the string to atimedeltaobject before it reachescalculate_update_interval.Test plan
🤖 Generated with Claude Code