Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Nov 7, 2025

Proposed Changes

SSIA

fixes #421

Summary by CodeRabbit

  • Chores
    • Removed deprecated configuration settings from addon configuration files to streamline setup.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Nov 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removed codenotary configuration from the bookstack addon across two files: eliminated the codenotary block containing base_image and signer fields from build.yaml, and removed the codenotary metadata field from config.yaml.

Changes

Cohort / File(s) Summary
Codenotary configuration removal
bookstack/build.yaml, bookstack/config.yaml
Removed codenotary configuration block from build.yaml (base_image and signer fields for all architectures) and removed the codenotary public configuration field from config.yaml

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward removal of configuration metadata with no logic changes or side effects to validate

Poem

🐰 The codenotary signs have faded away,
No more signatures to check and sway,
Configuration cleaned, simplified and bright,
The bookstack addon takes its new flight!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch frenck-2025-0427

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9f70aa and ae964aa.

📒 Files selected for processing (2)
  • bookstack/build.yaml (0 hunks)
  • bookstack/config.yaml (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit 1f14465 into main Nov 7, 2025
20 checks passed
@frenck frenck deleted the frenck-2025-0427 branch November 7, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add-on 'Bookstack' uses deprecated 'codenotary' field in config

2 participants