Skip to content

Dev branch#42

Merged
hvgazula merged 27 commits intohassonlab:mainfrom
VeritasJoker:dev_branch
Oct 26, 2022
Merged

Dev branch#42
hvgazula merged 27 commits intohassonlab:mainfrom
VeritasJoker:dev_branch

Conversation

@VeritasJoker
Copy link
Copy Markdown
Collaborator

Include changes from the other two PRs and more:

  1. pkl_hierarchy in correspondence with 247-pickling
  2. fixed encoding bug in encoding (fold=10, correct train/test fold and mean-centering)
  3. clean up some plotting code
  4. Fixed 'glove50' and 'glove' inconsistency (need to doublecheck)
  5. Added pca as argument

@VeritasJoker
Copy link
Copy Markdown
Collaborator Author

Still under development. Will test everything as I rerun all encoding on della.

@hvgazula
Copy link
Copy Markdown
Collaborator

My 2 cents: anything to do with embeddings should happen in pickling.. encoding should purely be encoding. Because..pickling is the feeder. Also, encoding is going out of control with too many code changes to account for new experiments.

@zkokaja
Copy link
Copy Markdown
Contributor

zkokaja commented Oct 26, 2022

Replace common = True with np array of all Trues. Remove commented out code and then we can merge this.

@hvgazula hvgazula merged commit 03e73d2 into hassonlab:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants