[experimental] optimise init queries on console #4489
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 17, 2020 00:17
wawhal
added
s/do-not-merge
|
Deploy preview for hasura-docs ready! Built with commit 98c0c87 |
Contributor
Author
|
/heroku deploy |
Contributor
|
Review app for commit 2dce0e8 deployed to Heroku: https://hge-ci-pull-4489.herokuapp.com |
Member
|
/heroku deploy |
Contributor
|
Review app for commit 60fee15 deployed to Heroku: https://hge-ci-pull-4489.herokuapp.com |
added 7 commits
April 22, 2020 15:07
Contributor
|
Review app for commit 98c0c87 deployed to Heroku: https://hge-ci-pull-4489.herokuapp.com |
hasura-bot
pushed a commit
that referenced
this pull request
May 27, 2022
### Description The main goal of this PR is, as stated, to remove the circular dependency in the schema building code. This cycle arises from the existence of remote relationships: when we build the schema for a source A, a remote relationship might force us to jump to the schema of a source B, or some remote schema. As a result, we end up having to do a dispatch from a "leaf" of the schema, similar to the one done at the root. In turn, this forces us to carry along in the schema a lot of information required for that dispatch, AND it forces us to import the instances in scope, creating an import loop. As discussed in #4489, this PR implements the "dependency injection" solution: we pass to the schema a function to call to do the dispatch, and to get a generated field for a remote relationship. That way, this function can be chosen at the root level, and the leaves need not be aware of the overall context. This PR grew a bit bigger than that, however; in an attempt to try and remove the `SourceCache` from the schema altogether, it changed a lot of functions across the schema building code, to thread along the `SourceInfo b` of the source being built. This avoids having to do cache lookups within a given source. A few cases remain, such as relay, that we might try to tackle in a subsequent PR. PR-URL: hasura/graphql-engine-mono#4557 GitOrigin-RevId: 9388e48372877520a72a9fd1677005df9f7b2d72
|
Rishichandra Wawhal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an experiemental PR trying to optimise the init queries on console.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components