Skip to content

console: add ErrorBoundary for VoyagerView and fix memory requirements of viz.js (close #4818) #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kolharsam wants to merge 42 commits into
base: master
Choose a base branch
from
Open

console: add ErrorBoundary for VoyagerView and fix memory requirements of viz.js (close #4818) #4856

kolharsam wants to merge 42 commits into from

Conversation

@kolharsam
Copy link
Contributor

@kolharsam kolharsam commented May 23, 2020 •
edited
Loading

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

Related Issues

#3023, should fix #4818

Solution and Design

The design is the same as the RuntimeError component, as suggested in #4818 one of the solutions is an Error Boundary specifically for the VoyagerView component. Which, now, has been implemented.

[x] Next would be to try and get to the root of the problem on the VoyagerView
The main problem being that for larger schema's and tables, the visualizer runs out of memory on the stack and so we had to rectify that by increasing the stack memory and buffer memory that is allocated to viz.js for rendering the graph

Steps to test and verify (to be changed)

  • First make 40+ tables on the GraphQL console
  • ~~You should see the fallback mentioned in the VoyagerErrBoundary component if an error does occur. ~~

Error screen
image

kolharsam added 2 commits May 23, 2020 09:11
@kolharsam
add VoyagerBoundary component
c61bfd4 
this will eventually end up enclosing the VoyagerView component
@kolharsam
add VoyagerErrBoundary component and enclose VoyagerView
49fcb80
@kolharsam kolharsam requested a review from a team as a code owner May 23, 2020 07:08
@hasura-bot

This comment has been minimized.

Sign in to view
@CLAassistant
Copy link

CLAassistant commented May 23, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kolharsam
✅ soorajshankar
❌ Sameer Kolhar

Sameer Kolhar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kolharsam kolharsam changed the title [WIP] Resolve[#4818] : Error Boundary for VoyagerView component [WIP] Resolve[#4818] : Error Boundary for VoyagerView May 23, 2020
@netlify
Copy link

netlify bot commented May 23, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 4a85374

https://deploy-preview-4856--hasura-docs.netlify.app

@kolharsam kolharsam changed the title [WIP] Resolve[#4818] : Error Boundary for VoyagerView resolve[#4818] : Error Boundary for VoyagerView May 27, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2020

Review app for commit bc66ec4 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-bc66ec40

@kolharsam kolharsam changed the title resolve[#4818] : Error Boundary for VoyagerView console: Error Boundary for VoyagerView resolve #4818 May 28, 2020
@kolharsam kolharsam changed the title console: Error Boundary for VoyagerView resolve #4818 console: Error Boundary for VoyagerView May 28, 2020
@kolharsam kolharsam requested a review from a team as a code owner May 28, 2020 05:28
@hasura-bot
Copy link
Contributor

hasura-bot commented May 28, 2020

Review app for commit d56f820 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-d56f8202

@beerose beerose self-assigned this May 28, 2020
@kolharsam kolharsam self-assigned this Jun 25, 2020
kolharsam
kolharsam commented Jun 27, 2020
View reviewed changes
Copy link
Contributor Author

@kolharsam kolharsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beerose have updated the component to TS.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 27, 2020

Review app for commit 63da193 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-63da193b

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 21, 2020

Review app for commit c68f6cd deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-c68f6cd8

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 22, 2020

Review app for commit f456ff2 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-f456ff21

soorajshankar
soorajshankar requested changes Jul 22, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 23, 2020

Review app for commit a02dce3 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-a02dce3d

@kolharsam kolharsam requested a review from soorajshankar July 23, 2020 06:22
@kolharsam kolharsam changed the title console: fix errors on VoyagerView console: add ErrorBoundary for VoyagerView and fix memory requirements of viz.js (close #4818) Jul 23, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 23, 2020

Review app for commit 6a5698c deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-6a5698ce

beerose
beerose suggested changes Jul 30, 2020
View reviewed changes
@kolharsam kolharsam requested a review from beerose July 30, 2020 09:47
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app for commit 25eba42 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-25eba425

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2020

Review app for commit f61a73e deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-f61a73e7

@beerose beerose mentioned this pull request Nov 17, 2020
Closed
@beerose beerose removed their assignment Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soorajshankar soorajshankar soorajshankar approved these changes

@beerose beerose Awaiting requested review from beerose

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

console: wrap voyager in error boundary

6 participants

@kolharsam @hasura-bot @CLAassistant @soorajshankar @beerose @rikinsk