do not fetch events if there are no event triggers #4873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit d256b14 |
tirumaraiselvan
force-pushed
the
event-trigger-reduce-fetches
branch
from
586bc21 to
13fda3d
Compare
tirumaraiselvan
force-pushed
the
event-trigger-reduce-fetches
branch
from
13fda3d to
d256b14
Compare
jberryman
reviewed
May 26, 2020
Collaborator
jberryman
left a comment
jberryman
left a comment
There was a problem hiding this comment.
What happens when a trigger is removed but there is a big backlog of events which haven't been processed yet? I guess they will persist in the DB until a new hook is added and then old events will be consumed and discarded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check if there are any event triggers configured before fetching batch of events. This reduces DB load in case event triggers are not used.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components