Skip to content

Conversation

@gr8shivam
Copy link
Contributor

@gr8shivam gr8shivam commented Oct 13, 2018

Description

Fixed minor errors present in .md files.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Fixes #735

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2018

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @gr8shivam, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@gr8shivam gr8shivam changed the title Fixed minor errors Fixed minor doc errors Oct 13, 2018
@shahidhk shahidhk changed the title Fixed minor doc errors typos in multiple files Oct 15, 2018
@shahidhk shahidhk added the c/docs Related to docs label Oct 15, 2018
@shahidhk shahidhk merged commit ddcd3dc into hasura:master Oct 15, 2018
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @gr8shivam! 💪 🏆 All of us at Hasura ❤️ what you did.

We would love to send you some swag! 👕 Please allow us to do so by filling this form.

If you have any questions, ask us on our Discord & Twitter!

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-730.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jun 19, 2024
<!-- Thank you for submitting this PR! :) -->

## Description

We cannot validate `BooleanExpressionType`s much until they are used.
This adds checks for when they are used as model `where` clauses. We
ensure the data connector in question is allowed to use nested filtering
(if we try and do any), and ensure that every scalar field has mappings
for the appropriate data connector.

Hidden behind a feature flag, so technically a no-op.

V3_GIT_ORIGIN_REV_ID: ab54f913157954e8197798febafc70012bfad9ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/docs Related to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor Doc Errors

4 participants