fix: pause-point disconnect no longer leaves Play Mode stuck; quiet-save before CLI Play#1756
Merged
Merged
Conversation
…k paused (#1754) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (21)
📝 WalkthroughWalkthroughThe PR adds shared quiet saving for dirty Unity scenes and Prefab Stages, blocks Play mode when saving fails or changes remain, and extends pause-point resume handling for clearing, capture expiry, and client disconnects. ChangesUnsaved editor changes
Pause-point resume and expiration
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant ControlPlayModeUseCase
participant EditorUnsavedChangesQuietSaver
participant UnityEditor
ControlPlayModeUseCase->>EditorUnsavedChangesQuietSaver: Save dirty editor changes
EditorUnsavedChangesQuietSaver->>UnityEditor: Save scenes and Prefab Stage
UnityEditor-->>EditorUnsavedChangesQuietSaver: Save results
ControlPlayModeUseCase->>EditorUnsavedChangesQuietSaver: Detect remaining changes
EditorUnsavedChangesQuietSaver-->>ControlPlayModeUseCase: Failure or remaining paths
ControlPlayModeUseCase-->>UnityEditor: Start Play mode only when clear
sequenceDiagram
participant ClientDisconnect
participant UloopPausePointRegistry
participant EditorUpdate
participant UnityEditor
ClientDisconnect->>UloopPausePointRegistry: Request editor resume
EditorUpdate->>UloopPausePointRegistry: Apply pending resume
UloopPausePointRegistry->>UnityEditor: Set editor pause state to false
EditorUpdate->>UloopPausePointRegistry: Apply capture-window expirations
UloopPausePointRegistry->>UnityEditor: Resume after expiration
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
LGTM (merge after required CI including Compile Check is green). Verified this umbrella contains exactly the two reviewed sub-PR squash merges (#1754 → 48c0155, #1755 → b9a6216) and the diff against v3-beta (24 files, +585/−146) matches the sum of the reviewed sub-PR diffs — no extra changes. The body correctly documents the approved Option B trade-off (auto-resume also clears a manual pause) and the resume-from-pause no-rewrite guarantee. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control-play-mode Playquietly saves dirty Scenes / Prefab Stage before Edit→Play (same path as run-tests)User Impact
DisconnectAllClientsresume Play Mode; Edit→Play auto-saves dirty editor assets or fails with an explicit listSub-PRs (already merged into this branch)
EditorUnsavedChangesQuietSaverOut of scope
Test plan
v3-beta)await-pause-pointHit, short commands do not resume until Clear/expiryuloop control-play-mode --action Play→ Scene saved, Play startsMade with Cursor