Skip to content

fix: Tighten v3 migration skill guidance and align wizard prompt#1981

Merged
hatayama merged 4 commits into
v3-betafrom
feature/v3-migration-skill-accuracy
Jul 24, 2026
Merged

fix: Tighten v3 migration skill guidance and align wizard prompt#1981
hatayama merged 4 commits into
v3-betafrom
feature/v3-migration-skill-accuracy

Conversation

@hatayama

@hatayama hatayama commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

The v3-cli-invocation-migration skill (installed into third-party projects via the migration wizard's "Install Migration Skill" button) predates several V3 changes. This PR fixes four accuracy problems found by re-auditing the skill against the current tool schemas and CLI flag-naming logic:

  1. Same-name option collisions: --wait-for-domain-reload and --include-inactive are listed as V2 migration targets, but they are now valid V3 positive flags on uloop execute-dynamic-code and uloop find-game-objects respectively. Added a "Same-Name Options on Other Commands" reference section and a command-scoping rule so agents do not remove or negate valid V3 usage by token match alone.
  2. No way to resolve unlisted first-party defaults: for first-party boolean options outside the special table, the skill never said how to find the V3 default. Added guidance to run uloop <command> --help and read the printed default: enabled / default: disabled.
  3. Repo-internal maintainer note leaked into the installed skill: the note referencing SkillTargetInstaller / skills.go deprecatedSkillNames is meaningless in third-party projects. Removed it from the skill and restated it as code comments above the two cleanup lists.
  4. Wizard prompt contradiction: the copyable AI prompt said "Migrate ... removed commands" while the skill treats removed commands as report-only. Reworded the prompt to match.

The special-options table itself was verified against cli/common/tools/default-tools.json and cli/common/tooldocs/tool_options.go and needed no changes.

Verification

  • scripts/check-go-cli.sh: format / vet / lint (0 issues) / tests all pass
  • dist/darwin-arm64/uloop compile: 0 errors, 0 warnings
  • rg "Installed-skill cleanup names" Packages/src/TemporarySkills~ and rg "and removed commands" Packages/src/Editor both return no hits

Review in cubic

hatayama added 3 commits July 24, 2026 19:28
The skill predates newer V3 commands, so token-level searches now
collide with valid V3 syntax: --wait-for-domain-reload is a positive
flag on execute-dynamic-code and --include-inactive on
find-game-objects. Document those collisions in a dedicated reference
section, tell agents to resolve defaults for unlisted first-party
booleans via "uloop <command> --help", and drop the repo-internal
maintainer note that shipped to third-party projects where
SkillTargetInstaller and skills.go do not exist.
The maintainer note removed from the installed migration skill still
matters to maintainers, so restate it where the cleanup lists live:
the dispatcher's deprecatedSkillNames and the Unity-side
SkillTargetInstaller now reference each other and the skill source.
The copyable AI prompt said "Migrate ... removed commands" while the
skill itself treats removed commands as report-only unless the user
explicitly asks. Reword the prompt so it no longer overrides the
skill's rule.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ca1442c-ae37-4953-8abd-83fd1c854b2d

📥 Commits

Reviewing files that changed from the base of the PR and between 9ab53d4 and 12a8ed7.

📒 Files selected for processing (1)
  • Packages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/references/first-party-v2-to-v3.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • Packages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/references/first-party-v2-to-v3.md

📝 Walkthrough

Walkthrough

The change updates V2-to-V3 CLI migration guidance, adds command-specific boolean and same-name option rules, separates removed-command reporting, and documents consistency between Unity cleanup names and dispatcher deprecated skill names.

Changes

V3 CLI migration guidance

Layer / File(s) Summary
Migration guidance and prompt updates
Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardText.cs, Packages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/*
Migration instructions now cover command-scoped option matches, boolean defaults from uloop <command> --help, same-name option exceptions, and separate reporting of removed commands.
Deprecated skill cleanup naming
Packages/src/Editor/Infrastructure/SkillSetup/SkillTargetInstaller.cs, cli/dispatcher/internal/dispatcher/skills.go
Comments document cleanup-name consistency and reference the V2-to-V3 migration guidance.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: tightening v3 migration guidance and aligning the wizard prompt.
Description check ✅ Passed The description accurately describes the skill and wizard prompt updates made in the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/v3-migration-skill-accuracy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@Packages/src/TemporarySkills`~/v3-cli-invocation-migration/Skill/references/first-party-v2-to-v3.md:
- Around line 81-84: Clarify the “Leave unchanged on” entries in the option
migration table so only already-bare flags remain unchanged on the listed
commands. Explicitly require value-bearing forms such as true/false variants to
follow the Boolean Argument Rules, while preserving the existing bare-flag V3
behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 44df7ca1-092b-4cad-87c2-dcc887d56f41

📥 Commits

Reviewing files that changed from the base of the PR and between 3b242a3 and 9ab53d4.

📒 Files selected for processing (5)
  • Packages/src/Editor/Infrastructure/SkillSetup/SkillTargetInstaller.cs
  • Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardText.cs
  • Packages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/SKILL.md
  • Packages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/references/first-party-v2-to-v3.md
  • cli/dispatcher/internal/dispatcher/skills.go

"Leave unchanged on" could be read as skipping value-bearing V2 forms
like "--wait-for-domain-reload true" on execute-dynamic-code. State
that only the already-bare flag is exempt and value-bearing forms
still follow the Boolean Argument Rules. Addresses CodeRabbit review.
@hatayama
hatayama merged commit 7c8a4a2 into v3-beta Jul 24, 2026
12 checks passed
@hatayama
hatayama deleted the feature/v3-migration-skill-accuracy branch July 24, 2026 10:47
@github-actions github-actions Bot mentioned this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant