Skip to content

fix: Windows CLI install no longer fails during binary verification#1152

Merged
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/fix-windows-cli-install-error
May 17, 2026
Merged

fix: Windows CLI install no longer fails during binary verification#1152
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/fix-windows-cli-install-error

Conversation

@hatayama
Copy link
Copy Markdown
Owner

Summary

  • Windows CLI install and update now avoid a staged executable name that Windows can treat as an installer.
  • Added focused installer harness coverage so the PowerShell installer keeps using a neutral staged executable name.

User Impact

  • Before, Windows CLI install could fail with uloop binary verification failed when the staged executable triggered Windows installer elevation behavior.
  • After, binary verification runs under a neutral staged filename, so the install can complete without an unexpected admin prompt.

Changes

  • Rename the PowerShell installer temporary directory prefix to uloop-stage-.
  • Rename the staged executable prefix from uloop-install- to uloop-staged-.
  • Add a regression check to the installer release-filter harness.

Verification

  • bash scripts/test-install-release-filter.sh
  • Windows PowerShell parse check for scripts/install.ps1
  • pwsh parse check for scripts/install.ps1
  • Local latest-beta PowerShell install smoke test
  • codex review --base origin/v3-beta

Windows treats executables named like installers as elevation-required programs in the user install directory, which made the pre-replace --version verification fail before uloop.exe was installed. Use a neutral staged filename and cover it in the installer harness so the verification path keeps running without an admin prompt.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Warning

Rate limit exceeded

@hatayama has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 7 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 45c7ae4c-cd1b-49b4-86f7-20c0d40d3d9e

📥 Commits

Reviewing files that changed from the base of the PR and between f12de85 and 99df9c2.

⛔ Files ignored due to path filters (1)
  • scripts/install.ps1 is excluded by none and included by none
📒 Files selected for processing (1)
  • scripts/test-install-release-filter.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/fix-windows-cli-install-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@hatayama hatayama merged commit 04abc42 into v3-beta May 17, 2026
6 checks passed
@hatayama hatayama deleted the feature/hatayama/fix-windows-cli-install-error branch May 17, 2026 11:12
@github-actions github-actions Bot mentioned this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant