Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
using System.Diagnostics;
using NUnit.Framework;

namespace io.github.hatayama.uLoopMCP.DynamicCodeToolTests
{
[TestFixture]
public class SharedRoslynCompilerWorkerHostTests
{
[Test]
public void ConfigureWorkerDotnetRuntimeEnvironment_WhenCalled_ShouldDisableMultilevelLookup()
{
ProcessStartInfo startInfo = new ProcessStartInfo();
startInfo.EnvironmentVariables[SharedRoslynCompilerWorkerHost.DotnetMultilevelLookupEnvironmentVariableName] = "1";

SharedRoslynCompilerWorkerHost.ConfigureWorkerDotnetRuntimeEnvironment(startInfo);

Assert.That(
startInfo.EnvironmentVariables[SharedRoslynCompilerWorkerHost.DotnetMultilevelLookupEnvironmentVariableName],
Is.EqualTo(SharedRoslynCompilerWorkerHost.DotnetMultilevelLookupDisabledValue));
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ internal static class SharedRoslynCompilerWorkerHost
private const string RoslynWorkerCompileResponseFileName = "RoslynCompilerWorker.rsp";
private const int SharedCompilerWorkerResponseTimeoutMilliseconds = 30000;
private const int WorkerAssemblyBuildTimeoutMilliseconds = 30000;
internal const string DotnetMultilevelLookupEnvironmentVariableName = "DOTNET_MULTILEVEL_LOOKUP";
internal const string DotnetMultilevelLookupDisabledValue = "0";

private static readonly object SharedCompilerWorkerLock = new();
private static Action<string> s_deleteWorkerDirectory = path => Directory.Delete(path, true);
Expand Down Expand Up @@ -486,7 +488,7 @@ private static ProcessStartInfo CreateWorkerStartInfo(
ExternalCompilerPaths externalCompilerPaths,
WorkerPaths workerPaths)
{
return new ProcessStartInfo
ProcessStartInfo startInfo = new ProcessStartInfo
{
FileName = externalCompilerPaths.DotnetHostPath,
Arguments = "exec"
Expand All @@ -500,6 +502,19 @@ private static ProcessStartInfo CreateWorkerStartInfo(
RedirectStandardError = false,
CreateNoWindow = true
};

ConfigureWorkerDotnetRuntimeEnvironment(startInfo);
return startInfo;
}

internal static void ConfigureWorkerDotnetRuntimeEnvironment(ProcessStartInfo startInfo)
{
Debug.Assert(startInfo != null, "startInfo must not be null");

// Why: global probing can select a system .NET 6 runtime while Unity 6000.4 worker
// references come from the bundled .NET 8 runtime, which breaks assembly binding.
startInfo.EnvironmentVariables[DotnetMultilevelLookupEnvironmentVariableName] =
DotnetMultilevelLookupDisabledValue;
}

private static WorkerAssemblyBuildResult CompileWorkerAssembly(
Expand Down Expand Up @@ -534,6 +549,7 @@ private static WorkerAssemblyBuildResult CompileWorkerAssembly(
RedirectStandardError = true,
CreateNoWindow = true
};
ConfigureWorkerDotnetRuntimeEnvironment(startInfo);

using Process process = ProcessStartHelper.TryStart(startInfo);
if (process == null)
Expand Down
Loading